Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CRD config plugin section #537

Merged
merged 15 commits into from
Oct 21, 2024
Merged

Adding CRD config plugin section #537

merged 15 commits into from
Oct 21, 2024

Conversation

maia-iyer
Copy link
Collaborator

closes #532

@maia-iyer
removed handlers
0c9b429 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
nit spacing fixes
f69d873 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
Nits
757d7fb 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
added plugin config parsing
39dbbe0 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
Nits
3564f61 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
Initialize Package
113fef3 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
add initial documentation
6de614f 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
added documentation
6b582af 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
nit lint
7c87907 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
nit
639793c 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
Add reference link
9047879 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer maia-iyer added backend Tornjak API (Backend) go Pull requests that update Go code labels Oct 11, 2024
@maia-iyer maia-iyer added this to the 2.0.0 milestone Oct 11, 2024
@maia-iyer maia-iyer self-assigned this Oct 11, 2024
@maia-iyer
nit lints
5386c6b 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
fix key length check
395e0e8 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
nit
a7d121b 
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer
nits
7cf7244 
Signed-off-by: Maia Iyer <[email protected]>
mamy-CS
mamy-CS approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maia-iyer maia-iyer merged commit 71a03a4 into main Oct 21, 2024
10 checks passed
@maia-iyer maia-iyer deleted the crd_config branch October 22, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamy-CS mamy-CS mamy-CS approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb lumjjb is a code owner

@mrsabath mrsabath Awaiting requested review from mrsabath mrsabath is a code owner

Assignees

@maia-iyer maia-iyer

Labels
backend Tornjak API (Backend) go Pull requests that update Go code Ready For Review
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Add SPIRE Controller Manager configuration Section
2 participants
@maia-iyer @mamy-CS