Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure correct version of SCT is installed in the release automation workflow #3524

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

joshuacwnewton
Copy link
Member

Checklist

GitHub

PR contents

Description

In #3383, I added a GitHub Actions workflow to automate the manual steps for creating a release. I had tested it on a separate repo, and it seemed to work OK.

However, I realize I made a mistake: In the GitHub action, I installed SCT from the release branch. This will generate the wrong requirements-freeze.txt; what I actually needed to do was:

  1. Install SCT from the master branch
  2. After the correct, up-to-date dependencies have been installed in the conda environment, then checkout the release branch and do the remaining steps (merge master, update requirements-freeze.txt and version.txt, etc.)

I've tested this once more in https://github.com/joshuacwnewton/test-github-actions/actions/runs/1271642941 and I feel confident that this will properly create a release in SCT.

Linked issues

N/A.

The full steps should be:

- Checkout main branch
- Install SCT
- Checkout release branch
- Merge main branch into release branch
- Generate new files (version.txt, requirements-freeze.txt)
- Commit new files and create release
@joshuacwnewton joshuacwnewton added the CI category: TravisCI, GitHub Actions, etc. label Sep 24, 2021
@joshuacwnewton joshuacwnewton added this to the 5.4 milestone Sep 24, 2021
Copy link
Contributor

@kousu kousu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright seems good!

Can we get rid of release eventually do you think?

@joshuacwnewton joshuacwnewton merged commit 9d78b1b into master Sep 27, 2021
@joshuacwnewton joshuacwnewton deleted the jn/fix-release-automation-workflow branch September 27, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI category: TravisCI, GitHub Actions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants