refactor(build): moved to gradle #5
Conversation
build.gradle
Outdated
| } | ||
|
|
||
| dependencies { | ||
| spinnaker.group('test') |
There was a problem hiding this comment.
I suspect the group('test') and testCompile groovy aren't necessary here?
There was a problem hiding this comment.
I need some of those test dependencies (junit) - should I just bring in that one instead of all of the group 'test'?
There was a problem hiding this comment.
I'd probably just add junit, our test group brings in spock and friends which we don't need (for now anyway)
build.gradle
Outdated
| description = "Redis embedded server for Java integration testing" | ||
| group = "com.netflix.spinnaker.embedded-redis" | ||
| apply plugin: 'spinnaker.project' | ||
| apply plugin: 'groovy' |
There was a problem hiding this comment.
could just make this apply plugin: 'java' and get rid of the tasks.compileGroovy.enabled line below
|
|
||
| <developers> | ||
| <developer> | ||
| <name>Krzysztof Styrc</name> |
There was a problem hiding this comment.
we should add an AUTHORS file including Krzysztof and also a top level LICENSE.txt file as in the other repos
There was a problem hiding this comment.
Ok done. Should we add the other authors mentioned in the README.md?
@cfieber PTAL, and let me know how to integrate this correctly with Travis/etc