Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(java11): Compile with Java 11 (but targeting Java 8) #1118

Merged
merged 1 commit into from
Mar 26, 2020
Merged

chore(java11): Compile with Java 11 (but targeting Java 8) #1118

merged 1 commit into from
Mar 26, 2020

Conversation

plumpy
Copy link
Member

@plumpy plumpy commented Mar 26, 2020

No description provided.

@plumpy plumpy requested a review from ezimanyi March 26, 2020 22:42
ezimanyi
ezimanyi approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation looks good!

@plumpy plumpy added the ready to merge Approved and ready for merge label Mar 26, 2020
@mergify mergify bot added the auto merged label Mar 26, 2020
@plumpy plumpy merged commit 4c59a6c into spinnaker:master Mar 26, 2020
@plumpy plumpy deleted the java11 branch March 26, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimanyi ezimanyi ezimanyi approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plumpy @ezimanyi @spinnakerbot