feat(pipeline_template): Pass along pipelineConfigId parameter for /pipelineTemplates/resolve
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jervi
force-pushed
the
support_previous_execution_context_for_pipeline_templates
branch
from
fbeed7e to
b961405
Compare
jervi
added a commit
to jervi/deck
that referenced
this pull request
Oct 31, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
added a commit
to jervi/deck
that referenced
this pull request
Oct 31, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
added a commit
to jervi/deck
that referenced
this pull request
Oct 31, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
added a commit
to jervi/deck
that referenced
this pull request
Oct 31, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
added a commit
to jervi/deck
that referenced
this pull request
Oct 31, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
added a commit
to jervi/deck
that referenced
this pull request
Oct 31, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
added a commit
to jervi/deck
that referenced
this pull request
Oct 31, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
added a commit
to jervi/deck
that referenced
this pull request
Nov 1, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
added a commit
to jervi/deck
that referenced
this pull request
Nov 2, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
|
@spinnaker/reviewers PTAL |
anotherchrisberry
pushed a commit
to spinnaker/deck
that referenced
this pull request
Nov 2, 2017
…dynamic sources (#4288) * feat(pipeline_template): Better support for templated pipelines with dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471 * Address PR comments * PR feedback + better error handling * Display an error message if the configuration cannot be rendered * New component for displaying execution name (supports build number, parent pipeline name and if nothing is provided, the timestamp) * PR feedback: use timestamp, move react2angular stuff, some cleanup
jervi
added a commit
to jervi/deck
that referenced
this pull request
Nov 3, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
added a commit
to jervi/deck
that referenced
this pull request
Nov 3, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
added a commit
to jervi/deck
that referenced
this pull request
Nov 6, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
Pass along pipelineConfigId and executionId parameters for `/pipelineTemplates/resolve`
jervi
force-pushed
the
support_previous_execution_context_for_pipeline_templates
branch
from
8cee365 to
ced5ae0
Compare
jervi
added a commit
to jervi/deck
that referenced
this pull request
Nov 6, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
added a commit
to jervi/deck
that referenced
this pull request
Nov 7, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
added a commit
to jervi/deck
that referenced
this pull request
Nov 8, 2017
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
danielpeach
pushed a commit
to spinnaker/deck
that referenced
this pull request
Nov 8, 2017
… dynamic sources - Take 2 (#4365) * feat(pipeline_template): Better support for templated pipelines with dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471 * fix(pipeline_template): Build execution title/numbers was rendered twice * fix(pipeline_template): PR feedback == --> === * PR feedback: don't swallow template exceptions
dkirillov
added a commit
to lookout/gate
that referenced
this pull request
Dec 6, 2017
* feat(gae): Adds endpoint to surfact GAE storage accounts. (spinnaker#470) * feat(echo/pubsub): Expose endpoint to query subscriptions. (spinnaker#472) * fix(pipeline_template): Default no scopes for pipeline templates (spinnaker#473) * feat(v2-canary): add application query param to config list endpoint (spinnaker#474) * fix(web): NPE when no scopes provided (spinnaker#475) * chore(canary-v2): Do not return bare strings. (spinnaker#477) * feat(pipeline_template): Support pipeline templates with dynamic sources (spinnaker#471) Pass along pipelineConfigId and executionId parameters for `/pipelineTemplates/resolve` * chore(swagger): Add webhooks endpoint to swagger docs (spinnaker#410) * fix(authN): Handle case of missing port(s) in post authN redirect. (spinnaker#467) - if port 443 is missing, but the scheme is https, we should set the default to 443, instead of -1. * feat(core): server group manager controller (spinnaker#478) * feat(pipelines): validate required parameters are supplied on pipeline trigger (spinnaker#479) * feat(core/serverGroups): Get a list of servergroups by name (spinnaker#480) Depends on spinnaker/clouddriver#2114 * feat(manifest): get manifest controller (spinnaker#481) * feat(xenial_builds): Add systemd configuration for Gate. (spinnaker#483) * feat(xenial_builds): Add systemd configuration for Gate. * chore(systemd_logs): Remove unneeded log redirection. (spinnaker#485) * feat(v2-canary): canary result endpoint, metric set list pair endpoint, refactoring (spinnaker#482) * feat(x509) Allow x509 and LDAP to be used together (spinnaker#476)
danielpeach
pushed a commit
to danielpeach/gate
that referenced
this pull request
May 24, 2018
…ces (spinnaker#471) Pass along pipelineConfigId and executionId parameters for `/pipelineTemplates/resolve`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.