Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pagerduty): Automatically append 'from' to the details map #1808

Merged
merged 1 commit into from
Nov 17, 2017
Merged

feat(pagerduty): Automatically append 'from' to the details map #1808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...cho/src/main/groovy/com/netflix/spinnaker/orca/echo/tasks/PageApplicationOwnerTask.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@ class PageApplicationOwnerTask implements RetryableTask {
}
}

def details = stage.context.details
if (details == null) {
details = [:]
}
if (details["from"] == null) {
details["from"] = stage.execution.authentication.user
}

// echo service will not send a proper response back if there is an error, it will just throw an exception
echoService.create(
new EchoService.Notification(
Expand All @@ -83,7 +91,7 @@ class PageApplicationOwnerTask implements RetryableTask {
source: new EchoService.Notification.Source(user: stage.execution.authentication.user),
additionalContext: [
message: stage.context.message,
details: stage.context.details
details: details
]
)
)
Expand Down