fix(rosco) Make baked artifacts adhere to the proposed standard #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
reviewed
Oct 12, 2017
| @@ -28,4 +28,7 @@ class Artifact { | |||
| String version | |||
| String reference | |||
| Map<String, String> metadata | |||
| String auth | |||
There was a problem hiding this comment.
This should be using the kork-artifacts package instead of recreating this here
There was a problem hiding this comment.
Cool, I hadn't seen the kork-artifacts. Fixing
| Artifact bakedArtifact = new Artifact( | ||
| name: bakeRecipe?.name, | ||
| version: bakeRecipe?.version, | ||
| type: cloudProvider, | ||
| type: "${cloudProvider}/image/${region}", |
There was a problem hiding this comment.
We're relying on the location field in the artifact definition for region
brujoand
force-pushed
the
adapt_created_artifacts_to_orcas_standard
branch
from
6ae5baf to
93e070a
Compare
|
Now using the |
brujoand
force-pushed
the
adapt_created_artifacts_to_orcas_standard
branch
from
93e070a to
ccc6e94
Compare
|
@lwander anything else we need to merge this? |
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 15, 2020
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the artifacts created in Rosco follow the same standard as those created in Orca (spinnaker/orca#1441)