Skip to content

Commit

Permalink
CI: run also on pull requests.
Browse files Browse the repository at this point in the history
Note: do not deploy on pull request events.
  • Loading branch information
GPMueller committed Jan 9, 2021
1 parent e9cd19a commit 64fc4e3
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: CI

on: [push]
on: [push, pull_request]

jobs:

Expand Down Expand Up @@ -251,6 +251,7 @@ jobs:
cmake --build . --config $BUILD_TYPE -j 2
deploy-pypi:
if: github.event_name != 'pull_request'
needs: test
runs-on: ${{ matrix.os }}
strategy:
Expand Down Expand Up @@ -312,10 +313,11 @@ jobs:
env:
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request'
if: github.ref == 'refs/heads/master'
run: twine upload --skip-existing dist/*

deploy-package:
if: github.event_name != 'pull_request'
needs: test
runs-on: ${{ matrix.os }}
strategy:
Expand Down

0 comments on commit 64fc4e3

Please sign in to comment.