fix(Logger): try to fmt runtime since it's not constexpr

- See scylladb/seastar#950
spjuanjoc · Jul 15, 2023 · 64ee381 · 64ee381
1 parent c466a01
commit 64ee381
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/include/Core/Logging/Logger.h b/include/Core/Logging/Logger.h
@@ -101,10 +101,10 @@ void Warn(const FormatString& fmt, Args&&... args)
 }
 
 template<typename FormatString, typename... Args>
-void Error(FormatString&& format_string, Args&&... args)
+void Error(const FormatString& fmt, Args&&... args)
 {
   SpdLogger::get();
-  spdlog::get(LOGGER_NAME)->error(std::forward<FormatString>(format_string), std::forward<Args>(args)...);
+  spdlog::get(LOGGER_NAME)->error(fmt::runtime(fmt), std::forward<Args>(args)...);
 }
 
 template<typename FormatString, typename... Args>

diff --git a/src/main.cpp b/src/main.cpp
@@ -42,6 +42,7 @@ int
 main(int argc, const char* argv[])
 {
   Logger::Info(">>main");
+  Logger::Error("test {} {}", "error", "string");
   auto args = Core::parseArguments(argc, argv);
   Logger::SpdLogger::get().setLevel(args.level);