Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable swap audit #44

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

Stable swap audit #44

wants to merge 50 commits into from

Conversation

AOranov
Copy link
Collaborator

@AOranov AOranov commented May 31, 2024

List of changes:

  • Got rid of abs() in fees validations inside the contract;
  • Flag "ampl_coeff_is_editable" is added to add the ability to fix "A" forever;
  • Imbalanced deposit/redeem operations were eliminated (now they are allowed only in pool reserves proportions);
  • Invariant validation procedure is optimized;

AOranov and others added 30 commits May 24, 2024 11:14
Got rid of abs() in the pool contract. "Ampl_coeff_is_editable" flag …
d9bab76 
…added to proxy-dao.
Invariant validation optimized +
e6d9cd0 
got rid of unbalanced operations
Fix LP delta validation
f547155
LP validation fixed and deposit/redeem test modified.
2d8fcfd
Specification update + typos fix.
0b4d50f
Removed unnecessary validations for deposit/redeem
f723847
LP fees equality fix.
9cc99cb
Spec text fix.
f10468c
Optimizations (WIP)
f0847b4
Opimized version.
6aaa016
Readme update
a7b9b2d
Swap image fix.
e1900ed
Redundant validation removed + fixed typos
566143a
Protocol fees conditions relaxed.
277c286
LP validation fix.
678431a
Spec updated
774914f
Exact validation fix.
74ec3b4
Orders fix.
1de42ee
Fixed stake cred missing validation.
d9768bb
Orders logic fix.
679e786
Orders validations fixes.
3140bbc
min_utxo value fix.
10924cf
@Bromel777
Add deposit and redeem for stable pool (#45)
8acf906
blueprint.
ce1bbe0
Redeem validation fix.
64ed87e
Softer condition for LP validation.
0d28fe4
Vulnerability 1: Restricted token dust attack.
db82cea
Vulnerability 05: Incorrect assumption in code
08d03a4
Vulnerability 2: Wrong usage of DAO action validator script
8dbf8a9
Remove unused order contracts.
7624472
AOranov and others added 20 commits July 15, 2024 17:19
Vulnerability 06: Inconsistent protocol fees
db7cd0e
Vulnerability 08: Pool invariant can be violated at dao change
0f8b727
Fmt.
dc67750
Optimize flags and actions.
8db5540
501 - proxy-DAO script purpose fix.
4cd578b
Pool NFT validation optimized.
6be0210
typo fix.
a1fe783
@Bromel777 @AOranov @oskin1
Dev-7. Weighted pools. For audit (#29)
a0824a5 
* Balance Pool. Swap, Deposit, Redeem, DepositSingleAsset operations

* cleanup

* fix treasury validation

* Redeem & Swap for random weights and fees fixes.

* Fixes and looped test example fixed.

* DEV-7. Balance pool. Optimizations (#36)

* DEV-7. Balance pools. Deposit, Redeem balance orders contracts (#30)

* add daoBalanceMintPolicyValidator

* DEV-7. Balance pool: optimizations, redundant logic removed. ValidDelta bug fix (#39)

* Balance pool. Optimizations, redundant logic removed, validDelta bug fix

* update balanceFeeSwitch

* remove redundant variable  in ppow10

* Fix incorrect flow in deposit, redeem contracts

* Balance pool. New approach (#43)

* New approach for balance pools

* remove invariant

* fix balance contract

---------

Co-authored-by: Ilya <[email protected]>

---------

Co-authored-by: AOranov <[email protected]>
Co-authored-by: Alex Oranov <[email protected]>
Co-authored-by: Ilya <[email protected]>
@Bromel777
CORE-329. Pool T2T (#46)
14f60b7 
* Update pool for t2t ops

* review cleanup
@oskin1
Open Grid Order N2T. CORE-343
c8578e5
@oskin1
Add min marginal output constraint to grid order.
6021a22
@oskin1
Grid datum docs.
6fc6c69
@oskin1
Clamp min_marginal_output in terminated limit orders. CORE-350
e097468
@oskin1
LO ignore IO without InlineDatu.
0b1b8e0
@Bromel777
CORE-379. Remove pool nft from dao v1 args list (#50)
de3333c
@Bromel777
Add deposit and redeem for stable pool (#45)
da09e87
blueprint.
14e72db
blueprint
d617145
@AOranov
Merge branch 'main' into stable-swap-audit
0b33d3a
blueprint update.
26b8d25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AOranov @Bromel777 @oskin1