Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search fails when enterering special characters #61

Closed
cufarvid opened this issue Jan 25, 2024 · 0 comments · Fixed by #62
Closed

Search fails when enterering special characters #61

cufarvid opened this issue Jan 25, 2024 · 0 comments · Fixed by #62

Comments

@cufarvid
Copy link
Contributor

This issue occurs because the special characters are not properly escaped when used in a regular expression pattern.

Steps to reproduce:

  1. Enter a special character like ( or [ in the expenses search field.
  2. The application will crash.
cufarvid added a commit to cufarvid/spliit that referenced this issue Jan 25, 2024
@cufarvid
Fix search functionality spliit-app#61
45e7716 
- use 'includes' for expense filtering
@cufarvid cufarvid mentioned this issue Jan 25, 2024
Merged
scastiel pushed a commit that referenced this issue Jan 26, 2024
@cufarvid
Fix search functionality (#62)
2228415 
* Improve README instructions for local setup

* Fix search functionality #61
- use 'includes' for expense filtering

* Ensure expense groups with no matching expenses are hidden after filtering

* Improve README instructions for local setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix search functionality cufarvid/spliit
1 participant
@cufarvid