-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic activity log #141
Conversation
nice! Might also be good to have the activity history for an individual expense at the bottom of the edit expense page. Also a +1 on getting the #95 infinite scroll PR merged! |
Could be nice if the expenses were links to the expense in question! |
@justcallmelarry They actually are linking to the expense, as long as it was not deleted in the meantime. This is denoted by the small arrows on the right (and a pointer cursor while hovering). |
@dcbr ah ok! nice! was not clear from the screenshot for me 😅 i was looking for the name of the group to be a link or similar |
This would also benefit from soft-deleting expenses, so that you can un-delete the expense from the log! |
@justcallmelarry Yes indeed! However, I didn't want to introduce too many changes here, and just introduce a basic version that can later be extended. But I agree soft-deletion would be a nice feature for a follow-up PR :) |
Hi @scastiel, could you please review and merge this feature when you have a chance? This is definitely required for the app. Thanks! |
@scastiel I think the app will benefit greatly from this PR |
Great idea! |
Thanks a lot @dcbr, amazing contribution! |
This PR adds a basic implementation for an activity log in each group. Currently 4 types of activity are logged: updating the group settings and creating/updating/deleting an expense. If an active user is configured, the activity message includes the name of that active user. If #95 is approved, the "infinite scroll" feature can also be applied to this activity log (the implementation here is derived from the expense list).
Related issues are #15, #103 and #106.