Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add group information field to group settings and Information tab #164

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

ChristopherJohnston
Copy link
Contributor

To close #108

I have added a group information field to the group form and a new "Information" tab to show the text (with a link to edit in group settings)

Group From

image

Information Tab

image

This could be enhanced with some formatting (perhaps markdown?) - particularly when rendering on the information tab.

@ChristopherJohnston ChristopherJohnston changed the title add group information field to group and Information tab to display add group information field to group settings and Information tab May 31, 2024
@ChristopherJohnston
Copy link
Contributor Author

added whitespace-break-spaces to classname so newlines are preserved

image

@ChristopherJohnston ChristopherJohnston marked this pull request as ready for review May 31, 2024 22:23
Copy link
Member

@scastiel scastiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I allowed myself to slightly improve the UX (with an edit button and some description), as well as update this with i18n.

@scastiel scastiel merged commit 972bb9d into spliit-app:main Aug 2, 2024
1 check passed
@ChristopherJohnston ChristopherJohnston deleted the add-group-description branch October 21, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request : Whiteboard in Group similar to splitwise
2 participants