Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization + Finnish language #181

Merged
merged 17 commits into from
Aug 2, 2024
Merged

Conversation

iqqmuT
Copy link
Contributor

@iqqmuT iqqmuT commented Jul 24, 2024

  • refers to Translations of the website #75
  • uses next-intl
  • locale auto-detected from user's browser by default
  • supported locales (in this PR):
    • en-US (fallback)
    • fi
  • locale used for number formatting
  • locale used for currency symbol positioning
  • changed locale is stored into a cookie
  • URL paths are not changed so old shared URLs keep working
  • easy to add a new locale:
    • create new file messages/LOCALE.json
    • add locale to src/i18n.ts

@scastiel
Copy link
Member

scastiel commented Aug 2, 2024

@iqqmuT This is so amazing! Let me review and test everything and let's get it merged! Internationalization is the # 1 asked feature for Spliit 🤩

@scastiel scastiel changed the title I18n Internationalization + Finnish language Aug 2, 2024
@scastiel scastiel merged commit 4f5e124 into spliit-app:main Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants