Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expense Date #24

Closed

Conversation

ChristopherJohnston
Copy link
Contributor

@ChristopherJohnston ChristopherJohnston commented Jan 7, 2024

Add expense date field, defaulting to today's date. This is assignable in the expense form.
Group expenses list will sort by this date in descending order

This resolves issue #17

Copy link

vercel bot commented Jan 7, 2024

@ChristopherJohnston is attempting to deploy a commit to the Sebastien Castiel Team on Vercel.

A member of the Team first needs to authorize it.

@ChristopherJohnston
Copy link
Contributor Author

...sorry, in an attempt to continue working with this + PR #25 I have merged the commits in this PR. So if this is looked at after the categories one then all should be fine in terms of merging

@scastiel
Copy link
Member

scastiel commented Jan 8, 2024

Hi @ChristopherJohnston, this is truly amazing, thanks for the contribution!

I’m very interested in storing/displaying an expense date, but I think categories require a bit more thinking… Do you think you could keep this PR only for the expense date? Hopefully this won’t be too much effort…

@ChristopherJohnston
Copy link
Contributor Author

Hi @ChristopherJohnston, this is truly amazing, thanks for the contribution!

I’m very interested in storing/displaying an expense date, but I think categories require a bit more thinking… Do you think you could keep this PR only for the expense date? Hopefully this won’t be too much effort…

sure - looks like all of this is behind your uneven split changes so I think it's easier that I close these PRs and start again - this one is a relatively simple change.

@ChristopherJohnston
Copy link
Contributor Author

closing as superseded by #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants