-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initialise a new totals tab with basic UI #94
feat: initialise a new totals tab with basic UI #94
Conversation
I don't have much to contribute here, but I thought I would suggest using "Stats" (or similar) instead of "Totals" as you could then expand it with other things, like spending charts etc raised in #82 |
Oh I agree. That would be much better. I was just making it closer to what splitwise has to offer but definitely could go with "Stats" and further add spending charts to it like you mentioned |
I'm also wondering if this takes into account not having a default active user set? It looks like it's still going through all of the expenses when it could just exit the functions in case the active user is |
Agreed, will make the change |
You can still wait for @scastiel to have some input 😄 he might have other previously unknown plans that clashes with the implementation for example. Just wanted to weigh in with my thoughts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s great, thanks for the contribution! We’ll be able to use the same tab to offer stats by category 😉
oh cool, maybe i can contribute to that too :D |
A new tab named 'Stats' with a simple UI that shows the group-level spending summary. Can be further extended to show other stats, charts, etc.
closes #93
Preview: