Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initialise a new totals tab with basic UI #94

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

meta-boy
Copy link
Contributor

@meta-boy meta-boy commented Feb 18, 2024

A new tab named 'Stats' with a simple UI that shows the group-level spending summary. Can be further extended to show other stats, charts, etc.
closes #93

Preview:

image

@justcallmelarry
Copy link
Contributor

I don't have much to contribute here, but I thought I would suggest using "Stats" (or similar) instead of "Totals" as you could then expand it with other things, like spending charts etc raised in #82

@meta-boy
Copy link
Contributor Author

Oh I agree. That would be much better. I was just making it closer to what splitwise has to offer but definitely could go with "Stats" and further add spending charts to it like you mentioned

@justcallmelarry
Copy link
Contributor

justcallmelarry commented Feb 20, 2024

I'm also wondering if this takes into account not having a default active user set? It looks like it's still going through all of the expenses when it could just exit the functions in case the active user is '' without doing any calculations (this is an improvement I would suggest in either case).
But will all the boxes still render? imo Total you paid for and Your total share should not show if you do not have an active user set.

@meta-boy
Copy link
Contributor Author

I'm also wondering if this takes into account not having a default active user set? It looks like it's still going through all of the expenses when it could just exit the functions in case the active user is '' without doing any calculations (this is an improvement I would suggest in either case).
But will all the boxes still render? imo Total you paid for and Your total share should not show if you do not have an active user set.

Agreed, will make the change

@justcallmelarry
Copy link
Contributor

I'm also wondering if this takes into account not having a default active user set? It looks like it's still going through all of the expenses when it could just exit the functions in case the active user is '' without doing any calculations (this is an improvement I would suggest in either case).
But will all the boxes still render? imo Total you paid for and Your total share should not show if you do not have an active user set.

Agreed, will make the change

You can still wait for @scastiel to have some input 😄 he might have other previously unknown plans that clashes with the implementation for example.
Just so that you do not spend time on changes for no reason.

Just wanted to weigh in with my thoughts

Copy link
Member

@scastiel scastiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s great, thanks for the contribution! We’ll be able to use the same tab to offer stats by category 😉

src/app/groups/[groupId]/stats/page.tsx Outdated Show resolved Hide resolved
@scastiel scastiel merged commit 2f991e6 into spliit-app:main Feb 28, 2024
1 check passed
@meta-boy
Copy link
Contributor Author

That’s great, thanks for the contribution! We’ll be able to use the same tab to offer stats by category 😉

oh cool, maybe i can contribute to that too :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: group spending tab similar to splitwise
3 participants