Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase retries and add delay backoff to connect to client on tests #554

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

lizardoluis
Copy link
Collaborator

@lizardoluis lizardoluis commented Jul 4, 2024

This PR makes the tests more robust against ConnectionRefused errors and ensure it retries the connection properly before panicking.

Changes Made:

  • Increased Retries: Changed the retry count from 3 to 5.
  • Exponential backoff: Instead of a fixed delay, now it uses a exponential backoff to gradually increase the wait time between retries. This can reduce the total wait time in successful cases while still allowing for enough time if the service is slow to start.
  • Logging: Added tracing for better logging to capture more information about each connection attempt and errors encountered.

@lizardoluis lizardoluis self-assigned this Jul 4, 2024
@lizardoluis lizardoluis force-pushed the fix_test_interleaving_queries_connection_refused branch from 1132121 to c183331 Compare July 4, 2024 09:02
@lizardoluis lizardoluis merged commit 61bff98 into main Jul 4, 2024
1 check passed
@lizardoluis lizardoluis deleted the fix_test_interleaving_queries_connection_refused branch July 4, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants