-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recorded Future for Splunk SOAR: Bug-fix - Release of app version 4.3.2 #19
Recorded Future for Splunk SOAR: Bug-fix - Release of app version 4.3.2 #19
Conversation
Thank you for your submission! We have a total of 16 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can. |
@JQvickWester Static Tests results for commit f22a484 - https://drive.google.com/file/d/1MfHu-f1w-nKBPx0feWykTkyOqvGkggtv/view?usp=drivesdk |
@JQvickWester Compile Tests results for commit f22a484 - https://drive.google.com/file/d/1__yHS3uO8yKOlf8bI8pLzc4vxIazz33K/view?usp=drivesdk |
@JQvickWester Static Tests results for commit 88a996b - https://drive.google.com/file/d/1xwXYWU5Hi-uoA6fZL9kDXFV7FbHQH9k-/view?usp=drivesdk |
@JQvickWester Compile Tests results for commit 88a996b - https://drive.google.com/file/d/1jD6czO5-F8SWXN3rSAl8V_Sl55DJ7Ccy/view?usp=drivesdk |
@JQvickWester Static Tests results for commit 8f365d3 - https://drive.google.com/file/d/18GNx4f1E0MZBgrRZXuyp-BjEL0uMWm2T/view?usp=drivesdk |
@JQvickWester Compile Tests results for commit 8f365d3 - https://drive.google.com/file/d/1oOjnQqhmH350OStyThDqayTl-l9LiCnI/view?usp=drivesdk |
Looking to get this merged, but I'm a bit confused about the @nestoor22 suggested that I reach out to you. Do you have any more details as to why this is failing? Thanks! |
The prodsec fail is caused by requests package, please remove it from requirements, as it is supplied by SOAR platform @JQvickWester |
@JQvickWester Static Tests results for commit 8efa1d5 - https://drive.google.com/file/d/1NNix-1BruPQvr5ZiBhIXcMNUYstmnKdz/view?usp=drivesdk |
@JQvickWester Compile Tests results for commit 8efa1d5 - https://drive.google.com/file/d/1_x84k78mbjySh0oXPBkIG9IHx2y-QIzb/view?usp=drivesdk |
@bb-splunk Thank you for you assistance, that cleared it up - have a great day! @nestoor22 looks like this is ready to merge, if you'd be so kind! |
Please ensure your pull request (PR) adheres to the following guidelines:
Pull Request Checklist
Please check if your PR fulfills the following requirements:
<App Name>: <PR Type> - <PR Description>
next
branch of the forked repo. Create separate feature branch for raising the PR.Pull Request Type
Please check the type of change your PR introduces:
Security Considerations (REQUIRED)
please document them in the
manual_readme_content.md
.manual_readme_content.md
all methods (eg, OAuth) used to authenticatewith the service that the connector is integrating with.
manual_readme_content.md
.the Vault API.
nosemgrep
?If yes, please provide justification in an additional comment next to the ignored code.
API key fingerprint is logged for debugging purposes.
Release Notes (REQUIRED)
What is the current behavior? (OPTIONAL)
What is the new behavior? (OPTIONAL)
Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)
Thanks for contributing!