Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recorded Future for Splunk SOAR: Bug-fix - Release of app version 4.3.2 #19

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

JQvickWester
Copy link
Contributor

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe): Copyright notice date update

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.
    API key fingerprint is logged for debugging purposes.

Release Notes (REQUIRED)

  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.
  • Improved visibility of support documents
  • Renaming of app headers
  • Fixing issues with hardcoded path for Cloud
  • Improved format for Intelligence Command Widgets
  • Added status config options for fetching standard and playbook alerts

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)


Thanks for contributing!

@splunk-soar-connectors-bot
Copy link
Collaborator

Thank you for your submission! We have a total of 16 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

@JQvickWester JQvickWester changed the title Recorded Future for Splunk SOAR 4.3.2 Recorded Future for Splunk SOAR: Bug-fix - Release of app version 4.3.2 Apr 3, 2024
@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@JQvickWester
Copy link
Contributor Author

Hi @dhwanis-crest

Looking to get this merged, but I'm a bit confused about the AWS CodeBuild us-west-2 (prodsec-scans) action that appears to be failing. Clicking details redirect me to an AWS login page.

@nestoor22 suggested that I reach out to you.

Do you have any more details as to why this is failing?

Thanks!

@bb-splunk
Copy link

The prodsec fail is caused by requests package, please remove it from requirements, as it is supplied by SOAR platform @JQvickWester

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@JQvickWester
Copy link
Contributor Author

@bb-splunk Thank you for you assistance, that cleared it up - have a great day!

@nestoor22 looks like this is ready to merge, if you'd be so kind!

@nestoor22 nestoor22 merged commit 8d6f192 into splunk-soar-connectors:next Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants