Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.9.0 - all changes #2

Merged
merged 20 commits into from
Dec 10, 2015
Merged

Release/0.9.0 - all changes #2

merged 20 commits into from
Dec 10, 2015

Conversation

shakeelmohamed
Copy link
Contributor

Please review @glennblock!

Do not merge until splunk/splunk-javascript-logging#2 is merged

@@ -1,5 +1,29 @@
# Splunk HTTP Event Collector Stream for Bunyan (beta)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop using the "beta" term here. .8 was the beta milestone.

@glennblock
Copy link

Overall LGTM, though a few comments

Shakeel Mohamed added 2 commits November 18, 2015 13:26
This token is unique to a Splunk
instance, this commit is made
for consistency with other examples.
shakeelmohamed added a commit that referenced this pull request Dec 10, 2015
Merge Release/0.9.0 into Develop
@shakeelmohamed shakeelmohamed merged commit 9c432ab into develop Dec 10, 2015
@shakeelmohamed shakeelmohamed deleted the release/0.9.0 branch December 10, 2015 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants