-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.9.0 - all changes #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The incorrect index error will only happen if an token is locked down to a specific index(es).
Specify the max number of retries when configuring a logger. The maximum backoff (time between retries) is capped at 2 minutes.
Also updated tests.
When this many events are in the contextQueue, flush() will be called.
TODO: - Make some decisions about middleware - Update remaining examples - Add a few timer tests for 100% coverage - Added ability to have custom event formatter - Context no longer has config or requestOptions - If !autoflush and any batching settings, throw an error - Simplified logic in many places - Added several util functions - Updated tests - Clarified the basic.js example
All batch settings will be ignored when they are <= 0.
Added remaining tests for utils
We have collectively decided that this feature does not provide enough value at this time.
This change optimizes the flush() function since events will only be serialized once after passed to send(). Without middleware, we no longer need to store un-serialized objects.
To disable autoFlush behavior, set all batching settings to 0. It is still enabled by default - flushing events 1 by 1. Modify this behavior through the config object.
LGTM |
@@ -1,5 +1,29 @@ | |||
# Splunk Logging Library for JavaScript (beta) | |||
|
|||
## v0.9.0 - beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop using beta here as well.
shakeelmohamed
force-pushed
the
release/0.9.0
branch
from
December 9, 2015 22:11
8f477de
to
0d3ea9f
Compare
shakeelmohamed
added a commit
that referenced
this pull request
Dec 10, 2015
Merge Release/0.9.0 into Develop
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the implementation @glennblock 😄