Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.9.0 - all changes #2

Merged
merged 47 commits into from
Dec 10, 2015
Merged

Release/0.9.0 - all changes #2

merged 47 commits into from
Dec 10, 2015

Conversation

shakeelmohamed
Copy link
Contributor

Please review the implementation @glennblock 😄

Shakeel Mohamed added 30 commits September 30, 2015 16:25
The incorrect index error will only happen
if an token is locked down to a specific index(es).
Specify the max number of retries when configuring
a logger. The maximum backoff (time between retries)
is capped at 2 minutes.
When this many events are in the contextQueue,
flush() will be called.
TODO:
- Make some decisions about middleware
- Update remaining examples
- Add a few timer tests for 100% coverage

- Added ability to have custom event formatter
- Context no longer has config or requestOptions
- If !autoflush and any batching settings, throw an error
- Simplified logic in many places
- Added several util functions
- Updated tests
- Clarified the basic.js example
All batch settings will be ignored when they are <= 0.
We have collectively decided that this feature
does not provide enough value at this time.
This change optimizes the flush() function
since events will only be serialized once
after passed to send().

Without middleware, we no longer need
to store un-serialized objects.
To disable autoFlush behavior, set all
batching settings to 0. It is still
enabled by default - flushing events
1 by 1. Modify this behavior through
the config object.
@glennblock
Copy link

LGTM

@@ -1,5 +1,29 @@
# Splunk Logging Library for JavaScript (beta)

## v0.9.0 - beta

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop using beta here as well.

shakeelmohamed added a commit that referenced this pull request Dec 10, 2015
Merge Release/0.9.0 into Develop
@shakeelmohamed shakeelmohamed merged commit 6bdf3fc into develop Dec 10, 2015
@shakeelmohamed shakeelmohamed deleted the release/0.9.0 branch December 10, 2015 18:47
@Senil84 Senil84 linked an issue May 9, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Irrenille
3 participants