Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sanic #14

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Add support for sanic #14

merged 3 commits into from
Aug 31, 2023

Conversation

chickenbellyfin
Copy link
Contributor

Adds a render() implementation to work with the Sanic framework.

sponsfreixes
sponsfreixes approved these changes Aug 19, 2023
View reviewed changes
Copy link
Owner

@sponsfreixes sponsfreixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! I added a couple of comments that are not show stoppers. I'll probably be able to merge this and release a new package to PyPI next week.

src/jinja2_fragments/sanic.py Outdated Show resolved Hide resolved
src/jinja2_fragments/sanic.py Outdated Show resolved Hide resolved
@chickenbellyfin
Copy link
Contributor Author

Updated. Good catch, this is mostly a modified vresion of the sanic_ext.

@sponsfreixes sponsfreixes merged commit 21495de into sponsfreixes:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sponsfreixes sponsfreixes sponsfreixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chickenbellyfin @sponsfreixes