Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add litestar support #26

Merged
merged 19 commits into from
Jan 30, 2024
Merged

Conversation

tataraba
Copy link
Contributor

Decided to add Litestar support by adding to the HTMXTemplate response class. I've added the example on the README, but let me know if you'd like a different approach.

Copy link
Owner

@sponsfreixes sponsfreixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments. I still need to run the tests myself, but looking good! Thanks for the submission!

src/jinja2_fragments/litestar.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tataraba
Copy link
Contributor Author

Okay, I made the changes and fixed a couple type annotations in the process (the return type for Litestar templates should just be Template).

Copy link
Owner

@sponsfreixes sponsfreixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I will include it on the next release.

@sponsfreixes sponsfreixes merged commit 1289e16 into sponsfreixes:main Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants