Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small QoL change to easy see failed tracks #1454

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Small QoL change to easy see failed tracks #1454

merged 1 commit into from
Jan 24, 2022

Conversation

othyn
Copy link
Contributor

@othyn othyn commented Jan 24, 2022

Small QoL change to easily see failed tracks

Description

(Okay this should be correctly aligned now.)

This is a really small change that simply shows the display_name of the track that has failed the lookup, so it can be easily referenced.

Related Issue

None

Motivation and Context

At the moment, when a track fails to be found on YouTube you are only presented with the phrase:

Could not match any of the results on YouTube. Skipping

This change is a really small change that simply shows the display_name of the track that has failed the lookup, so it can be easily referenced. E.g.

Could not match any of the results on YouTube for "Karl Jenkins, Carmine Lauri, David Alberman, London Symphony Orchestra - Palladio: 1. Allegretto (arr. for Strings Orchestra)". Skipping

This makes it really easy to find what has been skipped, as at the moment its really difficult to manually cross reference with the Spotify playlist to find what has been skipped, especially due to threading playing with the execution order.

How Has This Been Tested?

  • Arch: arm64
  • Env: macOS 12.1
  • Python: 3.10.1

Code is using the same print(f'my text') code format as the other string variable interpolation to remain consistent, nothing looks out of place.

Tested on an example run with the following output:

➜  ./lspotdl.sh https://open.spotify.com/playlist/60VVAgDtr5bEoJy2fpoIa2
Fetching Playlist...
Found YouTube URL for "Sir Sly - Welcomes The Pressure" : https://www.youtube.com/watch?v=FFNPMzniPZ0
Found YouTube URL for "Silver Maple - September Skies" : https://www.youtube.com/watch?v=FzNIiE_p3es
Found YouTube URL for "SHAED - Six In The Morning" : https://www.youtube.com/watch?v=ZJXZHrwx0oA
Found YouTube URL for "Sia - Elastic Heart" : https://www.youtube.com/watch?v=g40o6EpiEtM
Found YouTube URL for "Sigur Rós - Hoppípolla" : https://www.youtube.com/watch?v=L2eURgrgtiY
Found YouTube URL for "Sheryl Crow - All I Wanna Do" : https://www.youtube.com/watch?v=RiOtjXUpflY
Could not match any of the results on YouTube for "Karl Jenkins, Carmine Lauri, David Alberman, London Symphony Orchestra - Palladio: 1. Allegretto (arr. for Strings Orchestra)". Skipping
Found YouTube URL for "Shakira, Wyclef Jean - Hips Don't Lie (feat. Wyclef Jean)" : https://www.youtube.com/watch?v=o2H75PQdMHM
Found YouTube URL for "Skee-Lo - I Wish - Radio Edit" : https://www.youtube.com/watch?v=i8JfCSTqQYs

<etc.>

I checked the tests to find relevant impacted areas and couldn't find anything, so manual testing it is.

Running the automated tests via pytest are failing, but they appear to be unrelated to the change I have made, as they are failing on the active dev branch for me regardless, thus having to manually test the change.

Screenshots (if appropriate)

None, code example above of CLI output.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

Really small QoL change that makes it super easy to find failed tracks, as at the moment its not clear what song was not able to be found and takes an age to manually figure out what track failed.
@xnetcat
Copy link
Member

xnetcat commented Jan 24, 2022

Tests are broken smh. But I will merge this anyways.

Logging is already improved in v4

@othyn
Copy link
Contributor Author

othyn commented Jan 24, 2022

Super, thanks. At least its not just me haha

@xnetcat xnetcat merged commit 7424735 into spotDL:dev Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants