Small QoL change to easy see failed tracks #1454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small QoL change to easily see failed tracks
Description
(Okay this should be correctly aligned now.)
This is a really small change that simply shows the
display_name
of the track that has failed the lookup, so it can be easily referenced.Related Issue
None
Motivation and Context
At the moment, when a track fails to be found on YouTube you are only presented with the phrase:
This change is a really small change that simply shows the
display_name
of the track that has failed the lookup, so it can be easily referenced. E.g.This makes it really easy to find what has been skipped, as at the moment its really difficult to manually cross reference with the Spotify playlist to find what has been skipped, especially due to threading playing with the execution order.
How Has This Been Tested?
Code is using the same
print(f'my text')
code format as the other string variable interpolation to remain consistent, nothing looks out of place.Tested on an example run with the following output:
I checked the tests to find relevant impacted areas and couldn't find anything, so manual testing it is.
Running the automated tests via
pytest
are failing, but they appear to be unrelated to the change I have made, as they are failing on the activedev
branch for me regardless, thus having to manually test the change.Screenshots (if appropriate)
None, code example above of CLI output.
Types of Changes
Checklist