Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Tornado>=6 #2949

Closed
maresb opened this issue May 19, 2020 · 5 comments
Closed

Support Tornado>=6 #2949

maresb opened this issue May 19, 2020 · 5 comments

Comments

@maresb
Copy link

maresb commented May 19, 2020

Sorry to duplicate #2805, but I'm forced to uninstall Luigi from my JupyterLab environment since Tornado < 6 is breaking my extensions. Would you reconsider supporting Tornado 6? Thanks!

@honnix
Copy link
Member

honnix commented Jun 6, 2020

According to Tornado release notes: Python 2.7 and 3.4 are no longer supported; the minimum supported Python version is 3.5.2.

However Luigi still claims to support Python 3.3 and 3.4. So there are two options: 1) Luigi drops 3.3. and 3.4; 2) have more branches in setup.py. Wdyt @Tarrasch @dlstadther ? Both 3.3. and 3.4 have reached end of life, so it seems fair to drop them (we are not testing either of those anyway in CI).

@dlstadther
Copy link
Collaborator

I'm cool to drop mentioned support of 3.3 and 3.4

@honnix
Copy link
Member

honnix commented Jun 10, 2020

Cool. I will work on some PRs to follow this up.

@stonebig
Copy link

stonebig commented Aug 7, 2020

hum, still no hope for tornado>=6 support ? waiting for tornadoweb/tornado#2815 ?

@honnix
Copy link
Member

honnix commented Aug 10, 2020

@stonebig Sorry, blame me on this. I will make a few PRs to move this forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants