Drop Python 3.3 and 3.4 support #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allows more recent tornado version (>=6,<7).
dlstadther
approved these changes
Aug 10, 2020
|
@honnix |
|
@drowoseque Good catch. I thought we have no 33/34 in tox because readme says 36/ This PR intended to just officially drop the support declaration, but not clean up code base (which we can do in a follow-up PR). But yes this is good point. Thanks. |
|
OK. I see we don't run those as part of Travis CI. I now remember the change. :) |
drowoseque
approved these changes
Aug 10, 2020
dlstadther
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drop Python 3.3 and 3.4 support. Also allows more recent tornado version (>=6,<7).
Motivation and Context
Python 3.3 and 3.4 have reached end of life quite a while ago. This PR also addresses #2949.
Have you tested this? If so, how?
I installed Luigi under Python 2.7 and 3.6 and that worked as expected.