Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't call context managers directly, use the with statement #1433

Merged
merged 1 commit into from
Dec 1, 2015

Conversation

erikbern
Copy link
Contributor

Follow up on #1431

@erikbern erikbern force-pushed the erikbern/context-mgrs branch from 05a89de to 6a153f8 Compare November 29, 2015 17:15
@erikbern
Copy link
Contributor Author

this one keeps failing on the visualizer test, but everything else works

@Tarrasch
Copy link
Contributor

Could you look at disabling the intermittently failing visualizer tests? Maybe @stephenpascoe knows why?

@stephenpascoe
Copy link

The tests are failing because they expect 117 tasks to be in the scheduler but there are 162. The simulated task tree should be deterministic. I'll try it out locally.

@stephenpascoe
Copy link

When I grep the Travis logs for the visualiser tests I get 117 distinct tasks, as expected, but the scheduler says there are 162. My guess is that the scheduler has tasks in it from a previous test. I'd assumed it was isolated.

@Tarrasch
Copy link
Contributor

Tarrasch commented Dec 1, 2015

I guess it's not completely isolated. Doh.

@erikbern
Copy link
Contributor Author

erikbern commented Dec 1, 2015

did you change anything? not sure why it's building

anyway can i merge?

@Tarrasch
Copy link
Contributor

Tarrasch commented Dec 1, 2015

I don't think I re-triggered it no. Or I might have done and forgot ^^

Tarrasch added a commit that referenced this pull request Dec 1, 2015
don't call context managers directly, use the with statement
@Tarrasch Tarrasch merged commit 32b2752 into master Dec 1, 2015
@Tarrasch
Copy link
Contributor

Tarrasch commented Dec 1, 2015

Yes lets merge! :)

@Tarrasch Tarrasch deleted the erikbern/context-mgrs branch December 1, 2015 02:33
@erikbern
Copy link
Contributor Author

erikbern commented Dec 1, 2015

maybe i re-triggered the build. anyway thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants