Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make to call post_copy in postgres.CopyToTable.copy #1502

Merged
merged 2 commits into from
Jan 15, 2016

Conversation

woojing
Copy link
Contributor

@woojing woojing commented Jan 13, 2016

It seems just missing. so I filling.

@Tarrasch
Copy link
Contributor

Somebody knowing postgres should review this :)

@dlstadther
Copy link
Collaborator

LGTM. (Except that your second commit is meaningless here - needs rebase.)

I am the one who included the post_copy for rdbms and redshift. I also set up redshift to accept an optional property queries such that the post_copy method was already implemented. However, it is up to you whether you want to do the same/similar within postgres.py or if you want to leave it up to the user to implement their own post_copy().

erikbern added a commit that referenced this pull request Jan 15, 2016
Make to call post_copy in postgres.CopyToTable.copy
@erikbern erikbern merged commit 8c64217 into spotify:master Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants