luigid logging: Log less and change logger name #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it makes sense to log less, because currently I think INFO level should not be verbose. In particular "No workers connected" message is verbose and going to be said many more times than it will be actually removed (when used with assistants). Further, I think now is a sane time to change the name of the logger to the "recommended" `getLogger(__name__)` style. Because PR spotify#1633 was just merged and it's less likely that people have relied on the logger name prior to that.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes sense to log less, because currently I think INFO level
should not be verbose. In particular "No workers connected" message is
verbose and going to be said many more times than it will be actually
removed (when used with assistants).
Further, I think now is a sane time to change the name of the logger to
the "recommended"
getLogger(__name__)style. Because PR#1633 was just merged and it's less likely that people have
relied on the logger name prior to that.