Remove tracking url callback hack #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracking_url_callback was deprecated and didn't work with cythonized projects because cython modify some exception messages.
|
By analyzing the blame information on this pull request, we identified @daveFNbuck, @riga and @Tarrasch to be potential reviewers |
Current coverage is 76.14%@@ master #1722 diff @@
==========================================
Files 95 95
Lines 10358 10346 -12
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 8167 7878 -289
- Misses 2191 2468 +277
Partials 0 0
|
|
Sounds good to me, @daveFNbuck and @riga, any thoughts? |
|
It'll break my code, but I guess I've had 2 months to stop using the deprecated run function so I can't complain too much. |
|
Looks good to me. |
|
Thanks everyone |
p7k
pushed a commit
to Celmatix/luigi
that referenced
this pull request
Jul 11, 2016
* spotify/master: (25 commits) Version 2.2.0 Add tests for hashing parameters (spotify#1719) Update call to iteritems in luigi/tools/deps: deprecated in Python 3 (spotify#1749) Reset terminal colors in external_program (spotify#1742) Caches get_autoconfig_client on a per-thread basis Fix bug with GCSFlagTarget Add additional event handlers to tasks (spotify#1698) Reduce number of get_params calls in common_params. Removes redundant function definitions from rpc and server (spotify#1734) Fix salesforce default content type (spotify#1724) Rename MockTarget class variable _fn to path Remove MockTarget path property Deprecated LocalTarget fn propery Add note about underscore in parameter names (spotify#1729) Remove tracking url callback hack (spotify#1722) Consistent Luigi spelling in docs (spotify#1723) Update example_top_artists.rst (spotify#1662) Add combiner to docstrings in mrrunner Add luigi-deps-tree visualising tool (spotify#1680) Adding release step for Debian packages. (spotify#1718) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the deprecated tracking_url_callback hack in worker.py and its associated test.
As explained in #1707, the
if 'unexpected keyword argument' not in str(ex):doesn't play well with cython, so we agreed that it should be removed.I ran the fast tests, namely flake8, py27-nonhdfs and visualiser. I also cythonized my application and made sure I can call luigi without problem. I don't know much about luigi, but afaik it's pretty safe.
As requested, I'll add a branch on my github account with my cython test, in case somebody wants to play with it.