Allows clients to specify max_shown_tasks in task_list #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have some scripts that process task_list for reporting. When the response length goes beyond the maximum shown tasks, the scripts all break. In order to allow the scripts to keep reporting as things get backed up, this adds an optional argument to override the config's max shown tasks in task_list, while keeping the configured default for the visualizer.
|
Looks good to me! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional max_shown_tasks argument to task_list to override the server-configured value.
Motivation and Context
I have some scripts that process task_list for reporting. When the response length goes beyond the maximum shown tasks, the scripts all break. In order to allow the scripts to keep reporting as things get backed up, this adds an optional argument to override the config's max shown tasks in task_list, while keeping the configured default for the visualizer.
This could also potentially be used in the visualizer to make the number of tasks shown configurable by users.
Have you tested this? If so, how?
I included a unit test and I've been using this in production for about 3 months.