Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to task graphs in visualizer. #2025

Merged
merged 1 commit into from
Mar 6, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions luigi/static/visualiser/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ <h3 class="box-title">{{name}}</h3>
<div class="box-body">
Started: {{start_time}}<br>
Last Checkin: {{active}}<br>
Root Task: <a href="#{{{encoded_first_task}}}">{{first_task_display_name}}</a><br>
Root Task: <a href="#tab=graph&taskId={{{encoded_first_task}}}">{{first_task_display_name}}</a><br>
Running: {{num_running}}<br>
Pending: {{num_pending}}<br>
Unique Pending: {{num_uniques}}<br>
Expand All @@ -389,9 +389,9 @@ <h3 class="box-title">{{name}}</h3>
<td>{{priority}}</td>
<td>{{resources}}</td>
<td>{{displayTime}}</td>
<td><a href="#{{encodedTaskId}}" class="btn btn-info btn-xs" title="View graph" data-toggle="tooltip" data-action="drawGraph"><i class="fa fa-sitemap"/></a>
{{#trackingUrl}}<a target="_blank" href="{{trackingUrl}}" class="btn btn-primary btn-xs" title="Track Progress" data-toggle="tooltip"><i class="fa fa-eye"></i></a>{{/trackingUrl}}
{{#statusMessage}}<button class="btn btn-primary btn-xs statusMessage" title="Status message" data-toggle="tooltip" data-task-id="{{taskId}}" data-display-name="{{displayName}}"><i class="fa fa-comment"></i></button>{{/statusMessage}}
<td><a href="#tab=graph&taskId={{encodedTaskId}}" class="btn btn-info btn-xs" title="View graph" data-toggle="tooltip" data-action="drawGraph"><i class="fa fa-sitemap"/></a>
{{#trackingUrl}}<a target="_blank" href="{{trackingUrl}}" class="btn btn-primary btn-xs" title="Track Progress" data-toggle="tooltip"><i class="fa fa-eye"></i></a>{{/trackingUrl}}
{{#statusMessage}}<button class="btn btn-primary btn-xs statusMessage" title="Status message" data-toggle="tooltip" data-task-id="{{taskId}}" data-display-name="{{displayName}}"><i class="fa fa-comment"></i></button>{{/statusMessage}}
</td>
</tr>
{{/tasks}}
Expand Down
2 changes: 1 addition & 1 deletion luigi/static/visualiser/js/graph.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Graph = (function() {
name: task.name,
taskId: task.taskId,
status: task.status,
trackingUrl: "#"+task.taskId,
trackingUrl: "#tab=graph&taskId=" + task.taskId,
deps: deps,
params: task.params,
priority: task.priority,
Expand Down
2 changes: 1 addition & 1 deletion luigi/static/visualiser/js/visualiserApp.js
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ function visualiserApp(luigi) {
});
}
else {
window.location.href = 'index.html#taskId=' + taskId;
window.location.href = 'index.html#tab=graph&taskId=' + taskId;
}
});
}
Expand Down