Repaired luigi build

[Aaronhrndz]

Description

Changed URI.js route

Motivation and Context

Luigi does not build properly, referencing issue #2028

Have you tested this? If so, how?

The project has passed the travis tests, luigid is running properly.

[Tarrasch]

Can anyone else verify this works?

[Tarrasch]

Wasn't the issue the URI.js matching some regex? Do we not have the same issue here?

[Aaronhrndz]

In setup.py it copies the static files with this function:

def get_static_files(path):
return [os.path.join(dirpath.replace("luigi/", ""), ext)
for (dirpath, dirnames, filenames) in os.walk(path)
for ext in [".html", ".js", ".css", ".png",
".eot", ".svg", ".ttf", ".woff", "*.woff2"]]

The URI folder was called URI.js, and the above function fails when it gets this folder extension

[dlstadther]

It's been requested and (somewhat) supported by @nmb10 and @kwilcox to leave the version number within the path. So just change luigi/static/visualiser/lib/URI.js/1.18.2./URI.js to luigi/static/visualiser/lib/URI/1.18.2/URI.js.

[dlstadther]

lib/URI/1.18.2/URI.js

one too many /

[dlstadther]

@Tarrasch @nmb10 Are you good with this?

[nmb10]

Hi, @dlstadther . Yes.

[miku]

Can anyone else verify this works?

I believe this PR would fix the installation problem, that I encountered:

$ pip install luigi
....
error: can't copy 'luigi/static/visualiser/lib/URI.js': doesn't exist or not a regular file

In setup.py, get_static_files will return (among other globs) 'static/visualiser/lib/*.js',, which will match URI.js, which is not a regular file, as setup seems to expect.

[dlstadther]

Thanks!

[Lucas-C]

I have the same error when pip installing luigi 2.6.0. I cannot use this version in its current state.
Could you please include this fix in a 2.6.1 release ?

[dlstadther]

@Lucas-C I don't have the ability to push luigi releases. That'll have to wait until @Tarrasch returns.

[shahabedinh]

I had the same issue

/opt/cloudera/parcels/Anaconda-4.0.0/bin/pip install luigi

....
reating build/lib/luigi/static/visualiser/lib
copying luigi/static/visualiser/lib/mustache.js -> build/lib/luigi/static/visualiser/lib
copying luigi/static/visualiser/lib/jquery-1.10.0.min.js -> build/lib/luigi/static/visualiser/lib
error: can't copy 'luigi/static/visualiser/lib/URI.js': doesn't exist or not a regular file

then I download and then pip it.

wget https://github.com/spotify/luigi/archive/master.zip
unzip master.zip
cd luigi-master/
sudo /opt/cloudera/parcels/Anaconda/bin/pip install .

and it works for me