Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Python 3.6 #2053

Merged
merged 2 commits into from
Mar 7, 2017
Merged

Test against Python 3.6 #2053

merged 2 commits into from
Mar 7, 2017

Conversation

mewwts
Copy link
Contributor

@mewwts mewwts commented Mar 6, 2017

Description

Add Python 3.6 to build matrix in .travis.yml.

Motivation and Context

I want to run Luigi on Python 3.6. I have limited insight to tox, so I've made a basic attempt, but it might fail.

Have you tested this? If so, how?

Hoping travis will test this.

@mention-bot
Copy link

@mewwts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @freyes, @Tarrasch and @gpoulin to be potential reviewers.

@mewwts
Copy link
Contributor Author

mewwts commented Mar 6, 2017

The TOXENV=py33-nonhdfs is failing:

ERROR: InvocationError: '/home/travis/build/spotify/luigi/.tox/py33-nonhdfs/bin/coverage run test/runtests.py -v --ignore-files=(^\\.|^_|^setup\\.py$)'

But I think this is unrelated to py36?

Copy link
Contributor

@Tarrasch Tarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I feel a bit bad that we've not separated out the hdfs part and run all those tests on all changes. We're clearly wasting Travis's resources. But this PR is not the place to fix that. So LGTM.

@erikbern erikbern merged commit 7de45b5 into spotify:master Mar 7, 2017
@erikbern
Copy link
Contributor

erikbern commented Mar 7, 2017

nice!

This was referenced Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants