Set utf-8 encoding in the MIMEText constructor #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this is not set during the constructor, an exception is thrown in Python 2 when the e-mail body contains unicode.
daveFNbuck
force-pushed
the
unicode_email
branch
from
54143db to
bcdd4aa
Compare
With base64 encoding, the e-mail tests fail trying to validate subject and body contents. Using email.parser allows us to safely decode whatever encoding is used and verify the subject and body separately, resulting in slightly better validation as well.
daveFNbuck
force-pushed
the
unicode_email
branch
from
bcdd4aa to
82175fd
Compare
|
This is now tested in production, and I'm getting e-mails with unicode in them. Turns out R scripts use unicode single quotes around package names in error messages. |
|
@daveFNbuck Feeling good about this? Ready to merge? |
|
Yes, it was ready. |
|
Oh, forgot to say. Thanks for this PR @daveFNbuck :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass the e-mail encoding into the MIMEText constructor rather than
Motivation and Context
If this is not set during the constructor, an exception is thrown in Python 2 when the e-mail body contains unicode.
Have you tested this? If so, how?
Added a unit test, deployed to production but it'll take a while before I see any unicode e-mails.