Added worker-id command line parameter #2267
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a
--worker-id
which will be used for worker to identify itself. The user is expected to make sure these are unique.Motivation and Context
We needed to start and (safely) shutdown workers based on resource availability. In order to use
disable-worker
rpc call we needed the worker id. But there is no way to know the same. We can't rely on the included host name since we are using ECS to run the workers inside containersThis change allows us to set the worker-id using a known uuid and other details and use the same to disable it later.
Have you tested this? If so, how?
This is already available is a function parameter (which doesn't seem to be used anywhere). We tested it in our own setup without any issues.