Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added worker-id command line parameter #2267

Closed
wants to merge 1 commit into from
Closed

Added worker-id command line parameter #2267

wants to merge 1 commit into from

Conversation

TMaYaD
Copy link
Contributor

@TMaYaD TMaYaD commented Oct 24, 2017

Description

This change adds a --worker-id which will be used for worker to identify itself. The user is expected to make sure these are unique.

Motivation and Context

We needed to start and (safely) shutdown workers based on resource availability. In order to use disable-worker rpc call we needed the worker id. But there is no way to know the same. We can't rely on the included host name since we are using ECS to run the workers inside containers
This change allows us to set the worker-id using a known uuid and other details and use the same to disable it later.

Have you tested this? If so, how?

This is already available is a function parameter (which doesn't seem to be used anywhere). We tested it in our own setup without any issues.

@dlstadther
Copy link
Collaborator

@TMaYaD I've emailed Travis CI's support about our past few PR builds not going through. They seem to think it's due the fact that no one from your lexentbio org has ever logged into Travis before. Is there any way you or someone else from lexentbio (maybe @abhik) can do so and restart your PR builds? Thanks!

@TMaYaD
Copy link
Contributor Author

TMaYaD commented Oct 27, 2017

@dlstadther Done. Builds are running now. But all of the PRs are failing flake8 tests. I could use some help to fix those.

@dlstadther
Copy link
Collaborator

Interesting... I'm inclined to ignore some of these pep8 rules in the flake8 testing as they've gotten more strict and a little excessive IMO. I'm just not yet sure how to modify .travis.yml to add exclusions to the flake8 matrix

@stale
Copy link

stale bot commented Jul 31, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If closed, you may revisit when your time allows and reopen! Thank you for your contributions.

@stale stale bot added the wontfix label Jul 31, 2018
@stale stale bot closed this Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants