Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a task for MySQL #2553

Merged
merged 2 commits into from
Oct 21, 2018
Merged

Adding a task for MySQL #2553

merged 2 commits into from
Oct 21, 2018

Conversation

Marabou
Copy link
Contributor

@Marabou Marabou commented Oct 12, 2018

Description

  • A task that copies data to MySQL as a subclass of rdbms.CopyToTable.

Motivation and Context

  • There is no such task for MySQL.

Have you tested this? If so, how?

  • I have included unit tests
  • We use it in production at Bonnier News

Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dlstadther dlstadther merged commit 3cae745 into spotify:master Oct 21, 2018
dlstadther added a commit to dlstadther/luigi that referenced this pull request Nov 19, 2018
* upstream-master:
  Make Worker parameter task_process_context an OptionalParameter (spotify#2468) (spotify#2574)
  Version 2.8.0
  Implement configurable CORS.
  Add HdfsFlagTarget (spotify#2559)
  Fix HdfsAtomicWriteDirPipe.close() when using snakebite and the file do not exist. (spotify#2549)
  Small fix to logging in contrib/ecs.py (spotify#2556)
  [ImgBot] optimizes images (spotify#2555)
  Add CopyToTable task for MySQL (spotify#2553)
  Make capture_output non-positional in ExternalProgramTask (spotify#2547)
  Add Movio to list of Luigi users (spotify#2551)
  Interpolate environment variables in .cfg config files (spotify#2527)
  Fix ReadTheDocs build (spotify#2546)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants