Adapt SendGrid integration to use the updated libraries. #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlstadther
requested changes
May 24, 2019
|
Please take a look at failed tests. Looks like you'll need to fix the flake8 and update the test cfg for |
…t a kwarg for SendGridAPIClient anymore
|
jeez, that took way too long for me to understand what was going on. tests should all pass now. sorry for the back-and-forth - i'm not super familiar with travis/tox and unit testing in general. does this look good or should any more changes be done? |
This was referenced Jul 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SendGrid changed their API about three years ago to use API tokens instead of username/password combos. The
sendgridlibrary adapted, but Luigi's code that depends on SendGrid did not.Motivation and Context
This re-instates SendGrid integration for sending out emails when Luigi Tasks fail. It solves #2714 and #1956 (since they are duplicate issues).
Have you tested this? If so, how?
I ran a simple Task that force-failed by calling
sys.exit(), together with a config file using anapikeyvalue in[sendgrid]and amethod=sendgridon[email]. I received the "Task failed" emails, even with multiple email addresses set up.