Show task history link in visualizer when recording. #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure i'm totally following the appearance of the change. Could you fix the link to the image? (I'm getting 401) Glad to see new tests which are passing! |
|
@dlstadther I fixed the image link. |
GoodDok
pushed a commit
to GoodDok/luigi
that referenced
this pull request
Aug 23, 2019
* Show task history link in visualizer when recording. * Fix test.
GoodDok
pushed a commit
to GoodDok/luigi
that referenced
this pull request
Aug 23, 2019
* Show task history link in visualizer when recording. * Fix test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a link to the task history page (
/history) whenrecord_task_historyis enabled:To achieve that I
Schedulerthat returns therecord_task_historysetting,Motivation and Context
In some projects, easy browsing of the task history might be an important feature, so having a link in the top navigation bar seems like a good thing.
Tests
I added two simple tests that invoke the added rpc method and expect either True or False, depending on the
record_task_historysetting.