EnumListParameter #2801
Merged
EnumListParameter #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarrasch
suggested changes
Oct 11, 2019
There was a problem hiding this comment.
Looks really good! Thanks for adding this. Can you just remove the delim? I see that 1) the name delim sounds a bit sporadic is 2) untested and 3) undocumented. Only add code paths you have the time to give proper love too. :)
Or do you actually need a delim for your use case?
|
OK, I removed the delim param and renamed the underlying variable to |
Tarrasch
approved these changes
Nov 29, 2019
test for param default value
|
Travis for 2.7 was red, but it's gone now. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A parameter type complementary to EnumParameter that allows for an arbitrarily sized list (0 to n) of enum values in a str-delimited format.
Motivation and Context
Convenient addition to the Luigi parameter type inventory.
Have you tested this? If so, how?
I have included unit tests that match the style of existing
EnumParametertests.