Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed MockFile -> MockTarget #834

Merged
merged 1 commit into from
Mar 9, 2015
Merged

Renamed MockFile -> MockTarget #834

merged 1 commit into from
Mar 9, 2015

Conversation

erikbern
Copy link
Contributor

@erikbern erikbern commented Mar 8, 2015

I wonder if we should call it InMemoryTarget or something instead?

Also deleted some LocalTarget->MockTarget swapping in the global scope

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.05% when pulling c516582 on erikbern/mock-target into 0c08465 on master.

@erikbern erikbern force-pushed the erikbern/mock-target branch from c516582 to 9e615f9 Compare March 8, 2015 19:15
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 9e615f9 on spotify:erikbern/mock-target into 0c08465 on spotify:master.

@erikbern erikbern force-pushed the erikbern/mock-target branch from 9e615f9 to a038e7e Compare March 8, 2015 21:46
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling a038e7e on spotify:erikbern/mock-target into c6a3744 on spotify:master.

@erikbern erikbern force-pushed the erikbern/mock-target branch from a038e7e to f229eb3 Compare March 8, 2015 21:51
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling f229eb3 on spotify:erikbern/mock-target into 67912ab on spotify:master.

Renamed MockFile -> MockTarget
d830e78 
I wonder if we should call it InMemoryTarget or something instead?

Also deleted some LocalTarget->MockTarget swapping in the global scope

Fixed an issue with the test coverage for LocalFile (constructor wasn't run)
@erikbern erikbern force-pushed the erikbern/mock-target branch from f229eb3 to d830e78 Compare March 8, 2015 22:37
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling d830e78 on spotify:erikbern/mock-target into 67912ab on spotify:master.

erikbern pushed a commit that referenced this pull request Mar 9, 2015
Merge pull request #834 from spotify/erikbern/mock-target
10064c8 
Renamed MockFile -> MockTarget
@erikbern erikbern merged commit 10064c8 into master Mar 9, 2015
@erikbern erikbern deleted the erikbern/mock-target branch March 9, 2015 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikbern @landscape-bot