Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc failure for scio-bigquery with 2.11.12, bad constant pool tag 19 #2308

Closed
nevillelyh opened this issue Oct 15, 2019 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@nevillelyh
Copy link
Contributor

nevillelyh commented Oct 15, 2019

To repro:

sbt ++2.11.12 scio-bigquery/doc

Error:

[error]   bad constant pool tag 19 at byte 56                                                                                                                                                                                                                                                                                                                                               
[error]      while compiling: /home/neville/src/spotify/scio/scio-bigquery/src/main/scala/com/spotify/scio/bigquery/validation/SetProperty.scala                                                                                                                                                                                                                                            
[error]         during phase: globalPhase=terminal, enteringPhase=parser                                                                                                                                                                                                                                                                                                                    
[error]      library version: version 2.11.12                                                                                                                                                                                                                                                                                                                                               
[error]     compiler version: version 2.11.12
...
[error]   last tree to typer: Ident(annottees)                                                                                                                                                                                                                                                                                                                                              
[error]        tree position: line 41 of /home/neville/src/spotify/scio/scio-bigquery/src/main/scala/com/spotify/scio/bigquery/validation/SetProperty.scala                                                                                                                                                                                                                                 
[error]             tree tpe: annottees.type                                                                                                                                                                                                                                                                                                                                                
[error]               symbol: value annottees                                                                                                                                                                                                                                                                                                                                               
[error]    symbol definition: annottees: c.Expr[Any]* (a TermSymbol)                                                                                                                                                                                                                                                                                                                        
[error]       symbol package: com.spotify.scio.bigquery.validation                                                                                                                                                                                                                                                                                                                          
[error]        symbol owners: value annottees -> method setPropertyImpl -> object SetProperty                                                                                                                                                                                                                                                                                               
[error]            call site: method setPropertyImpl in object SetProperty in package validation                                                                                                                                                                                                                                                                                            
[error]                                                                                                                                                                                                                                                                                                                                                                                     
[error] == Source file context for tree position ==                                                                                                                                                                                                                                                                                                                                         
[error]                                                                                                                                                                                                                                                                                                                                                                                     
[error]     38   def setPropertyImpl(c: blackbox.Context)(annottees: c.Expr[Any]*): c.Expr[Any] = {                                                                                                                                                                                                                                                                                         
[error]     39     setSystemProperty()                                                                                                                                                                                                                                                                                                                                                      
[error]     40     annottees.head                                                                                                                                                                                                                                                                                                                                                           
[error]     41   }                                                                                                                                                                                                                                                                                                                                                                          
[error]     42 }
...
[error]   last tree to typer: Ident(annottees)
[error]        tree position: line 41 of /home/neville/src/spotify/scio/scio-bigquery/src/main/scala/com/spotify/scio/bigquery/validation/SetProperty.scala
[error]             tree tpe: annottees.type
[error]               symbol: value annottees
[error]    symbol definition: annottees: c.Expr[Any]* (a TermSymbol)
[error]       symbol package: com.spotify.scio.bigquery.validation
[error]        symbol owners: value annottees -> method setPropertyImpl -> object SetProperty
[error]            call site: method setPropertyImpl in object SetProperty in package validation
[error] 
[error] == Source file context for tree position ==
[error] 
[error]     38   def setPropertyImpl(c: blackbox.Context)(annottees: c.Expr[Any]*): c.Expr[Any] = {
[error]     39     setSystemProperty()
[error]     40     annottees.head
[error]     41   }
[error]     42 }
[error] Total time: 18 s, completed Oct 15, 2019 2:15:50 PM

Possibly related to:
scala/bug#11635

@nevillelyh nevillelyh added the bug Something isn't working label Oct 15, 2019
@nevillelyh
Copy link
Contributor Author

After bisection I narrowed it down to the jackson 2.10.0 bump. Probably due to Java 9 style module-info.
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.10#changes-compatibility

@nevillelyh
Copy link
Contributor Author

I can't figure out an sbt classpath hack to work around this, reverting the version bump.

@regadas
Copy link
Contributor

regadas commented Oct 30, 2019

both sbt "++2.12.10 scio-bigquery/doc" sbt "++2.11.12 scio-bigquery/doc" work fine.

@regadas
Copy link
Contributor

regadas commented Oct 31, 2019

Closing this for now

@regadas regadas closed this as completed Oct 31, 2019
@nevillelyh nevillelyh reopened this Dec 11, 2019
@nevillelyh
Copy link
Contributor Author

Still broken for me, this is blocking 0.8.0 release.

@nevillelyh
Copy link
Contributor Author

Really closing this for good. The workaround is ugly but does the job, plus we're not counting on another 2.11 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants