Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Auto Generated Forms Fields Layouts #10673

Merged
merged 7 commits into from
Jan 13, 2021
Merged

Fix Auto Generated Forms Fields Layouts #10673

merged 7 commits into from
Jan 13, 2021

Conversation

MatthewKennedy
Copy link
Contributor

@MatthewKennedy MatthewKennedy commented Jan 12, 2021 •
edited
Loading

  • CSS fix so the contents of the Accounts menu don't overflow the rounded corners.
  • Improve the layout of form elements generated by the preference_field_for helper.

@squash-labs
Copy link

squash-labs bot commented Jan 12, 2021

Manage this branch in Squash

Test this branch here: https://matthewkennedymaster-qfdzc.squash.io

@MatthewKennedy MatthewKennedy changed the title Add overflow hidden to account menu. Fix Auto Generated Forms Fields Layouts Jan 13, 2021
damianlegawiec
damianlegawiec approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@damianlegawiec damianlegawiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MatthewKennedy 👍

@damianlegawiec damianlegawiec merged commit bdc255f into spree:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianlegawiec damianlegawiec damianlegawiec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewKennedy @damianlegawiec