Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct bug about the order when routes are refreshed by group #3112

Merged

Conversation

ilozano2
Copy link

@ilozano2 ilozano2 commented Oct 23, 2023

Correct bug about the order when routes are refreshed by group

Steps to reproduce it without this fix

  1. POST a route with order 1000 and group:1 in the metadata ("route-order-1000"
  2. POST /refresh?metadata=group:1
  3. Check the route was refreshed - GET /gateway/routes
  4. POST a route with order 0 and group:2 in the metadata ("route-order-0"
  5. POST /refresh?metadata=group:2
  6. Check the order of the refreshed routes GET /gateway/routes

Expected: the ordered list will be "route-order-0" first, then "route-order-1000"
Currently: the ordered list is in the wrong order, having "route-order-0" at the end

@ilozano2 ilozano2 changed the base branch from main to 4.0.x October 23, 2023 14:17
@spencergibb spencergibb added this to the 4.0.8 milestone Oct 31, 2023
@spencergibb spencergibb merged commit ee9d6ad into spring-cloud:4.0.x Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants