Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.adoc #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rajvansh11
Copy link

corrected spelling mistakes

corrected spelling mistakes

Signed-off-by: Priyank Rajvansh <[email protected]>
@Rajvansh11 Rajvansh11 force-pushed the documentation-changes branch from bcdf365 to 8e5bcbd Compare January 24, 2025 16:54
@Rajvansh11
Copy link
Author

@robertmcnees can you please have a look at this?This is my first open source contribution,tho not much I would be grateful if its accepted.

@robertmcnees
Copy link
Contributor

Hi @Rajvansh11. Thanks for the PR. In my opinion, the spring guides are a fantastic place to get some open source experience. The team sometimes labels issue for just this purpose. Try this search link to look across multiple repositories.

Unfortunately I am no longer a maintainer of these projects, so I won't be able to help get your PR merged (or help merge any of the other issues that you'll see in the search above).

Specific to this PR, it looks like you submitted it without any problems. I'd only comment that this project already has open PRs #130 and #135 that fix the issues you found. If I were maintaining the project, I tend to take the earlier PRs and close this one as a duplicate. Not my call to make here, but in general make sure to check existing issues before submitting a PR so you don't end up doing work that doesn't get merged.

@Rajvansh11
Copy link
Author

Hii @robertmcnees ,Thanks a lot for the advice,really grateful :)
I shall definitely check the open PRs from the next time before starting on working on one.

Once again ,thanks a lot .Hope you have a great day ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants