This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
Added Flag to Disable Base Path Removal #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added property `removeBasePath` to `proxyIntegrationConfig` This will allow users to disable the default functionality of removing the `/basepath` from incoming requests. If this looks okay I'll update documentation accordingly.
…o deafult to true in order to not break original functionality
|
Please let me know if there's more I can/ need to do for this PR. Thanks, |
|
Hi @EthanDavis , thank you for your PR. It's a first approach to get around the "ugly hack". If I ever have time 😞 |
|
@chgohlke Yeah I know it's not the greatest work around. Thanks for the approval and merge though! When will this be released? Also I'm interested in helping to maintain this library. Anywhere specifically I could start? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added property
removeBasePathtoproxyIntegrationConfigThis will allow users to disable the default functionality of removing the/basepathfrom incoming requests when they have a custom domain. If this looks okay I'll update documentation accordingly.