Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getCustomerId to the interface #19

Merged
merged 4 commits into from
Sep 1, 2020
Merged

add getCustomerId to the interface #19

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
225c382
add getCustomerId to the interface
art333 Aug 31, 2020
c435c02
add clientId parameter to the getCustomerId func
art333 Aug 31, 2020
63f7bd7
add docu for clientId param
art333 Aug 31, 2020
e338d49
add docu for clientId param
art333 Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/ps-web-apis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ export interface WhoamiV1 {
* @return {WhoamiUserInfo} some relevant userdata
*/
getUserInfo(): Promise<WhoamiUserInfo>;
/**
* will request customer pseudo id for currently logged user from consent backend
*/
getCustomerId(additionalParameter?: Map<string, string[]>): Promise<string>;
art333 marked this conversation as resolved.
Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mich wundert nur dass es hier keine spezifischen parameter gibt... welche additional parameters gibt es denn?

das typing soll ja eigtl. helfen wenn man das modul nutzt. so frag ich mich was ich da mitgeben kann und warum

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"clientId" ist so ein pflicht parameter. Ich dachte ich mache mir alle parameters als additional ^^ aber ok ich habe jetzt noch "clientId: string" da hinzugefügt

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aber was sind denn die additional parameters? ... das ist so als ob du in java zu Object castest und das ist dann die API

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schonmal generisch für alle alle kommenden Parameter vorbereitet? ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja ich dachte erst dass wir es generisch machen wollen wie bei doLogin, doRegister und so :D aber egal ich habe nur das "clientId" da gelasen. Erst sollte es passen :D

}

export function whoamiV1(): Promise<WhoamiV1> {
Expand Down