Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for consumer batching #1032

Closed
garyrussell opened this issue Jun 24, 2019 · 1 comment · Fixed by #1033 or #1037
Closed

Add support for consumer batching #1032

garyrussell opened this issue Jun 24, 2019 · 1 comment · Fixed by #1033 or #1037
Assignees
Milestone

Comments

@garyrussell
Copy link
Contributor

Currently, consumer batching (providing the listener with the complete batch in one call) only applies when the producer creates the batch.

With the SimpleMessageListenerContainer, it should be relatively easy with its existing infrastructure to support presenting the listener with a batch of discrete messages.

  • deprecate txSize in favor of batchSize
  • add enableConsumerBatching
  • create a "short" batch if no messages received in receiveTimeout.
  • add a new default methods to MessageListener isBatchConsumer() and onMessageBatch()
@garyrussell garyrussell added this to the 2.2.M4 milestone Jun 24, 2019
@garyrussell garyrussell self-assigned this Jun 24, 2019
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jun 24, 2019
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jun 24, 2019
artembilan pushed a commit that referenced this issue Jun 26, 2019
Resolves #1032

* Missing Javadocs
* Still De-Batch producer batches if so configured
* Polishing; detect incorrect configuration.
* Revert to generic message for incorrect configuration.
@garyrussell
Copy link
Contributor Author

Still needs work for @RabbitListener.

@garyrussell garyrussell reopened this Jun 26, 2019
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jun 27, 2019
Resolves spring-projects#1032

Add basic consumer batching support to the `@RabbitListener` infrastructure.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jun 27, 2019
Resolves spring-projects#1032

Add basic consumer batching support to the `@RabbitListener` infrastructure.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jun 28, 2019
Resolves spring-projects#1032

Add basic consumer batching support to the `@RabbitListener` infrastructure.
artembilan pushed a commit that referenced this issue Jun 28, 2019
Resolves #1032

Add basic consumer batching support to the `@RabbitListener` infrastructure.

* * Polishing - simplify batch configuration in container factories
* Add a test to ensure producer debatching works for DMLC too

* * Add more tests

* * Fix javadoc; add one more test

* * Fix type in test name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant