Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple BrokerRunning from JUnit4 #1071

Closed
garyrussell opened this issue Aug 20, 2019 · 0 comments · Fixed by #1072
Closed

Decouple BrokerRunning from JUnit4 #1071

garyrussell opened this issue Aug 20, 2019 · 0 comments · Fixed by #1072
Assignees
@garyrussell
Labels
type: enhancement
Milestone
2.2.RC1

Comments

@garyrussell
Copy link
Contributor

BrokerRunning is used by the JUnit5 BrokerRunningCondition; decouple the code so that no JUnit 4 classes are required.
@garyrussell garyrussell added this to the 2.2.RC1 milestone Aug 20, 2019
@garyrussell garyrussell self-assigned this Aug 20, 2019
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Aug 20, 2019
@garyrussell
spring-projectsGH-1071: JUnit 5 Support Improvements
bb8428b 
Resolves spring-projects#1071

- Remove JUnit4 dependency from `RabbitAvailableCondition` (minor breaking API change)
- Add `purgeAfterEach` to `@RabbitAvailable`
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Aug 20, 2019
@garyrussell
spring-projectsGH-1071: JUnit 5 Support Improvements
2c2a749 
Resolves spring-projects#1071

- Remove JUnit4 dependency from `RabbitAvailableCondition` (minor breaking API change)
- Add `purgeAfterEach` to `@RabbitAvailable`
- tabs not spaces in `RabbitAvailableCondition` (review with `?w=1`)
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Aug 20, 2019
@garyrussell
spring-projectsGH-1071: JUnit 5 Support Improvements
6bf29c9 
Resolves spring-projects#1071

- Remove JUnit4 dependency from `RabbitAvailableCondition` (minor breaking API change)
- Add `purgeAfterEach` to `@RabbitAvailable`
- tabs not spaces in `RabbitAvailableCondition` (review with `?w=1`)
- `@LogLevels` now requires `level`
@garyrussell garyrussell mentioned this issue Aug 20, 2019
Merged
artembilan pushed a commit that referenced this issue Aug 21, 2019
@garyrussell @artembilan
GH-1071: JUnit 5 Support Improvements
50c17ea 
Resolves #1071

- Remove JUnit4 dependency from `RabbitAvailableCondition` (minor breaking API change)
- Add `purgeAfterEach` to `@RabbitAvailable`
- tabs not spaces in `RabbitAvailableCondition` (review with `?w=1`)
- `@LogLevels` now requires `level`

* Sonar, javadoc fixes; default log level,  per review comments; convert more tests.

* Remove unnecessary `defaultPort` field; 2 more conversions
garyrussell added a commit that referenced this issue Aug 21, 2019
@garyrussell
GH-1071: Retain stacktrace when broker required
958806a
garyrussell added a commit that referenced this issue Aug 21, 2019
@garyrussell
GH-1071: Retain stacktrace when broker required
28e9103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
type: enhancement
Projects
None yet
Milestone
2.2.RC1
Development

Successfully merging a pull request may close this issue.

GH-1071: JUnit 5 Support Improvements garyrussell/spring-amqp
1 participant
@garyrussell