Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeclarableCustomizer or similar #1125

Closed
garyrussell opened this issue Nov 24, 2019 · 0 comments · Fixed by #1126
Closed

Add DeclarableCustomizer or similar #1125

garyrussell opened this issue Nov 24, 2019 · 0 comments · Fixed by #1126
Assignees
@garyrussell
Labels
type: enhancement
Milestone
2.2.2

Comments

@garyrussell
Copy link
Contributor

garyrussell commented Nov 24, 2019 •
edited
Loading

Add some mechanism to allow the admin the pre-process Declarable objects (e.g. add arguments) before declaring.

Supports spring-attic/spring-cloud-stream-binder-rabbit#274
@garyrussell garyrussell self-assigned this Nov 24, 2019
@garyrussell garyrussell mentioned this issue Nov 24, 2019
Closed
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Nov 25, 2019
@garyrussell
spring-projectsGH-1125: Add DeclarableCustomizer
73324ac 
Resolves spring-projects#1125
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Nov 25, 2019
@garyrussell
spring-projectsGH-1125: Add DeclarableCustomizer
29ffb4b 
Resolves spring-projects#1125

- pull up the common `arguments` field to `AbstractDeclarable`
- add `x-single-active-consumer` as a first class `QueueBuilder` argumemt
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Nov 25, 2019
@garyrussell
spring-projectsGH-1125: Add DeclarableCustomizer
1470e74 
Resolves spring-projects#1125

- pull up the common `arguments` field to `AbstractDeclarable`
- add `x-single-active-consumer` as a first class `QueueBuilder` argumemt
@garyrussell garyrussell mentioned this issue Nov 25, 2019
Merged
@garyrussell garyrussell added this to the 2.2.2 milestone Nov 25, 2019
artembilan pushed a commit that referenced this issue Nov 25, 2019
@garyrussell @artembilan
GH-1125: Add DeclarableCustomizer
e6e659a 
Resolves #1125

- pull up the common `arguments` field to `AbstractDeclarable`
- add `x-single-active-consumer` as a first class `QueueBuilder` argumemt

* Doc polishing

* Add back default ctor; fix default return from removeArgument().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
type: enhancement
Projects
None yet
Milestone
2.2.2
Development

Successfully merging a pull request may close this issue.

GH-1125: Add DeclarableCustomizer garyrussell/spring-amqp
1 participant
@garyrussell