Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DeBatching Producer Batches in the DMLC #1201

Closed
garyrussell opened this issue May 15, 2020 · 0 comments · Fixed by #1202 or #1203
Closed

Support DeBatching Producer Batches in the DMLC #1201

garyrussell opened this issue May 15, 2020 · 0 comments · Fixed by #1202 or #1203
Assignees
@garyrussell
Labels
backport:2.2.x (obsolete) type: improvement
Milestone
2.3.M1

Comments

@garyrussell
Copy link
Contributor

Also with the SMLC, even when consumer-side batching is not enabled.

https://stackoverflow.com/questions/61822464/directmessagelistenercontainer-is-it-possible-to-use-with-batchmessagelistener/61823993#comment109352702_61823993
@garyrussell garyrussell added this to the 2.3.M1 milestone May 15, 2020
@garyrussell garyrussell self-assigned this May 15, 2020
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue May 15, 2020
@garyrussell
spring-projectsGH-1201: Native BatchMessageListener Support
960b061 
Resolves spring-projects#1201

Support de-batching producer batches to a `List<Meessage>` with native
`BatchMessageListener`s; previously this was only possible with
`@RabbitListener` which does the debatching itself.
@garyrussell garyrussell mentioned this issue May 15, 2020
Merged
artembilan pushed a commit that referenced this issue May 18, 2020
@garyrussell
GH-1201: Native BatchMessageListener Support
751326e 
Resolves #1201

Support de-batching producer batches to a `List<Meessage>` with native
`BatchMessageListener`s; previously this was only possible with
`@RabbitListener` which does the debatching itself.

* Fix race in test.

#1202 (comment)

The test has a very short timeout; there is a race such that the channel won't be
physically closed if we don't get the `ConsumeOK` in time.

This won't really cause a problem in a real application, but this change will
prevent the test from sporadically failing.
artembilan pushed a commit that referenced this issue May 18, 2020
@garyrussell @artembilan
GH-1201: Native BatchMessageListener Support
6abdd27 
Resolves #1201

Support de-batching producer batches to a `List<Meessage>` with native
`BatchMessageListener`s; previously this was only possible with
`@RabbitListener` which does the debatching itself.

* Fix race in test.

#1202 (comment)

The test has a very short timeout; there is a race such that the channel won't be
physically closed if we don't get the `ConsumeOK` in time.

This won't really cause a problem in a real application, but this change will
prevent the test from sporadically failing.
# Conflicts:
#	src/reference/asciidoc/amqp.adoc
@garyrussell garyrussell reopened this May 18, 2020
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue May 18, 2020
@garyrussell
spring-projectsGH-1201: Fix for ChannelAwareBatchMessageListener
3f1b0eb 
Resolves spring-projects#1201

The previous commit did not work with `ChannelAwareBatchMessageListener`.

Also add a test to get `List<o.s.a.c.Message>` in a `@RabbitListener` (which
exposed this issue).
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue May 18, 2020
@garyrussell
spring-projectsGH-1201: Fix for ChannelAwareBatchMessageListener
5f50a6f 
Resolves spring-projects#1201

The previous commit did not work with `ChannelAwareBatchMessageListener`.

Also add a test to get `List<o.s.a.c.Message>` in a `@RabbitListener` (which
exposed this issue).

**cherry-pick to 2.2.x**
@garyrussell garyrussell mentioned this issue May 18, 2020
Merged
artembilan pushed a commit that referenced this issue May 19, 2020
@garyrussell @artembilan
GH-1201: Fix for ChannelAwareBatchMessageListener
095b2df 
Resolves #1201

The previous commit did not work with `ChannelAwareBatchMessageListener`.

Also add a test to get `List<o.s.a.c.Message>` in a `@RabbitListener` (which
exposed this issue).

**cherry-pick to 2.2.x**
artembilan pushed a commit that referenced this issue May 19, 2020
@garyrussell @artembilan
GH-1201: Fix for ChannelAwareBatchMessageListener
a2119b3 
Resolves #1201

The previous commit did not work with `ChannelAwareBatchMessageListener`.

Also add a test to get `List<o.s.a.c.Message>` in a `@RabbitListener` (which
exposed this issue).

**cherry-pick to 2.2.x**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
backport:2.2.x (obsolete) type: improvement
Projects
None yet
Milestone
2.3.M1
1 participant
@garyrussell